Display all of the following, not just Foreman #6730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bdunne
commented
Mar 4, 2020
bdunne
commented
- ConfigurationManager
- ConfiguredSystem
- ConfigurationProfile
|
@miq-bot assign @h-kataria |
|
Not sure if we want to merge this in this state or if it needs more discussion. |
|
@h-kataria It's not clear to me how to fix the remaining spec failure. |
- ConfigurationManager - ConfiguredSystem - ConfigurationProfile
|
Checked commit bdunne@c5a59a4 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint |
|
merging this PR, need to create a follow up PR to rename all the file names to not be specific to foreman. |
|
Thanks for the help on this one @h-kataria |
h-kataria
added a commit
to h-kataria/manageiq
that referenced
this pull request
Mar 11, 2020
Renamed provider_foreman specific features, links etc to configuration_manager Follow up PR for ManageIQ/manageiq-ui-classic#6730
2 tasks
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Mar 11, 2020
- Renamed views, controllers and other files to not be specific to provider_foreman - Renamed methods and actions, routes etc to use `configuration_manager` - Changed any links to point to `configuration_manager` instead of `provider_foreman` follow up PR for ManageIQ#6730
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Mar 11, 2020
- Renamed views, controllers and other files to not be specific to provider_foreman - Renamed methods and actions, routes etc to use `configuration_manager` - Changed any links to point to `configuration_manager` instead of `provider_foreman` follow up PR for ManageIQ#6730
Fryguy
reviewed
Mar 11, 2020
| Classification.bulk_reassignment(:model => "ConfiguredSystem", | ||
| :object_ids => @configured_system.id, | ||
| Classification.bulk_reassignment(:model => "ManageIQ::Providers::Foreman::ConfigurationManager", | ||
| :object_ids => @config_mgr.id, |
There was a problem hiding this comment.
@bdunne Did this one go backwards?
There was a problem hiding this comment.
@h-kataria helped to get this test passing.
it's due to the fact that we removed match_via_descendants from tree building code it wasnt getting the correctly tagged object back
h-kataria
added a commit
to h-kataria/manageiq
that referenced
this pull request
Mar 20, 2020
Renamed provider_foreman specific features, links etc to configuration_manager Follow up PR for ManageIQ/manageiq-ui-classic#6730
3 tasks
h-kataria
added a commit
to h-kataria/manageiq
that referenced
this pull request
Apr 2, 2020
Renamed provider_foreman specific features, links etc to configuration_manager Follow up PR for ManageIQ/manageiq-ui-classic#6730
h-kataria
added a commit
to h-kataria/manageiq
that referenced
this pull request
Apr 9, 2020
Renamed provider_foreman specific features, links etc to configuration_manager Follow up PR for ManageIQ/manageiq-ui-classic#6730
simaishi
pushed a commit
that referenced
this pull request
May 18, 2020
Display all of the following, not just Foreman (cherry picked from commit 9e5201a)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.