Add my_queue_name for ems_operations miq_requests

[agrare]

Add a queue name for all of the ems_operations MiqRequest classes

#19543

[lfu]

I'm wondering whether all MiqRequest classes belong to ems_operations. If that is the case, the same change would/should be applied to all MiqRequest classes? @gmcculloug What do you think?

[gmcculloug]

Here is the list of classes that derive from MiqRequest. Most, but not all use ems_operations.

• MiqRequest (role = nil)
  • AutomationRequest (role = automate)
  • MiqProvisionConfiguredSystemRequest
  • MiqProvisionRequest
    • MiqProvisionRequestTemplate
  • MiqRetireRequest (inherits from parent)
    • OrchestrationStackRetireRequest (inherits from parent)
    • ServiceRetireRequest (inherits from parent)
    • VmRetireRequest (inherits from parent)
  • PhysicalServerFirmwareUpdateRequest
  • PhysicalServerProvisionRequest
  • ServiceReconfigureRequest
  • ServiceTemplateProvisionRequest (conditional either 'automate' : 'ems_operations')
    • ServiceTemplateTransformationPlanRequest (inherits from parent)
  • VmCloudReconfigureRequest
  • VmMigrateRequest
  • VmReconfigureRequest

[agrare]

Yeah I was going through the obvious ones first, ones with a clear "source" object that I can use to get the queue_name from. But intend to go through all of the MiqRequestTask classes that have the ems_operations role.

[gmcculloug]

@agrare As discussed can you add tests for the classes that have existing specs. Looks like that would include these:

app/models/configured_system.rb
app/models/physical_server.rb
app/models/physical_server_firmware_update_request.rb

I opened issue #19771 to create tests for the following classes that do not have tests today:

app/models/miq_provision_configured_system_request.rb
app/models/vm_cloud_reconfigure_request.rb
app/models/vm_migrate_request.rb

[miq-bot]

Checked commits agrare/manageiq@6cb7e9c~...197e18c with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
11 files checked, 0 offenses detected
Everything looks fine. ⭐

[agrare]

@gmcculloug 👍 done