Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queue_name to all ems_operations queue roles #19543

Closed
agrare opened this issue Nov 21, 2019 · 5 comments
Closed

Add queue_name to all ems_operations queue roles #19543

agrare opened this issue Nov 21, 2019 · 5 comments
Assignees

Comments

@agrare
Copy link
Member

agrare commented Nov 21, 2019

In order to allow providers to bring their own OperationsWorkers, we need to support a queue_name for all ems_operations type work.

Example: #19479, #19544

Parent issue: ManageIQ/manageiq-providers-vmware#484

@djberg96
Copy link
Contributor

djberg96 commented Dec 3, 2019

Probably shoulda put this list here, but for now: ManageIQ/manageiq-providers-vmware#484 (comment)

@chessbyte
Copy link
Member

@agrare @djberg96 seems that all the PRs related to this issue have been merged. Is there more work to be done or can this issue be closed as completed?

@djberg96
Copy link
Contributor

I think we can close it, but I don't have the power to. I'll leave it to @agrare. :)

@agrare
Copy link
Member Author

agrare commented Jan 20, 2020

There are a few more that we still need to do, e.g. #19705

All of the subclasses of MiqRequest that use the ems_operations role need to have my_queue_name set.

@agrare
Copy link
Member Author

agrare commented Jan 28, 2020

All known ems_operations methods have queue names so I'm going to close this issue out

@agrare agrare closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants