Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set my_queue_name for MiqProvisionRequests #19705

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Jan 9, 2020

We need to set the queue_name for any ems_operations queue items, this
includes the first one and any requeue_phase calls.

#19543

@djberg96
Copy link
Contributor

👍

Copy link
Member

@gmcculloug gmcculloug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good. Needs spec test.

We need to set the queue_name for any ems_operations queue items, this
includes the first one and any requeue_phase calls.
@agrare agrare force-pushed the set_queue_name_for_provision_requests branch from 7a114bd to 8d51e61 Compare January 20, 2020 17:45
@miq-bot
Copy link
Member

miq-bot commented Jan 20, 2020

Checked commit agrare@8d51e61 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍪

@agrare
Copy link
Member Author

agrare commented Jan 20, 2020

@gmcculloug okay spec test added

@gmcculloug gmcculloug merged commit 3140fa8 into ManageIQ:master Jan 21, 2020
@gmcculloug gmcculloug added this to the Sprint 128 Ending Jan 20, 2020 milestone Jan 21, 2020
@agrare agrare deleted the set_queue_name_for_provision_requests branch January 21, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants