Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Prefer block version of File.open to ensure file handle gets automatically closed" #19427

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Revert "Prefer block version of File.open to ensure file handle gets automatically closed" #19427

merged 1 commit into from
Oct 22, 2019

Conversation

jrafanie
Copy link
Member

Reverts #19412

We're giving developers 2 weeks to get off ruby 2.4 and I pulled trigger too early.

@jrafanie jrafanie requested a review from Fryguy October 22, 2019 16:32
@Fryguy Fryguy merged commit 4a9e7ae into master Oct 22, 2019
@jrafanie jrafanie deleted the revert-19412-prefer_block_version_of_File_open branch October 22, 2019 16:33
@Fryguy Fryguy added this to the Sprint 123 Ending Oct 28, 2019 milestone Oct 22, 2019
@Fryguy Fryguy self-assigned this Oct 22, 2019
@jrafanie jrafanie mentioned this pull request Oct 22, 2019
Merged
@kbrock
Copy link
Member

kbrock commented Oct 23, 2019

this is why we can't have nice things...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

Assignees

@Fryguy Fryguy

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrafanie @kbrock @Fryguy