Prefer block version of File.open to ensure file handle gets automatically closed

[chessbyte]

No description provided.

[djberg96]

I'm not sure what ruby 2.4.x is complaining about. Maybe adding an ensure instead of using the block form will make it happy. It might be a little more readable in this case, too.

[jrafanie]

@chessbyte can you rebase? #19414 was merged so we won't be testing ruby 2.4 anymore on master. 2.5 and 2.6.

[djberg96]

@jrafanie Ah, I hadn't realized that was merged. You can probably disregard my comment then. :)

[jrafanie]

@jrafanie Ah, I hadn't realized that was merged. You can probably disregard my comment then. :)

yeah, it was pretty uncontroversial since you can still bundle with 2.4. We only test in travis on 2.5 and 2.6 now.

[miq-bot]

Checked commit chessbyte@2082460 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

[jrafanie]

I reverted this PR because we're giving devs 2 weeks to get off of ruby 2.4. See #19427