Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update puma to latest. Be less conservative. #19389

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Oct 11, 2019

Puma does a pretty good job about following semantic versioning so it should be safe to update minor versions and will probably help us tackle the problems sooner rather than later.

https://github.com/puma/puma/blob/v4.2.1/History.md

  • Depends on some UI team members 👍. It works for me but I didn't test puma:
    • with a debugger (tested by @himdel, thanks 🙇🙇🙇 )
    • consoles with websockets (tested by @skateman, thanks 🙇🙇🙇 )
    • action cable with notifications (tested by @skateman, thanks 🙇🙇🙇 )

Puma does a pretty good job about following semantic versioning so it should be safe to update minor versions
and will probably help us tackle the problems sooner rather than later.

https://github.com/puma/puma/blob/v4.2.1/History.md
@skateman
Copy link
Member

Just to clarify, consoles are NOT using action cable 😉 only notifications. However, consoles are also running through websockets.

@miq-bot miq-bot added the wip label Oct 11, 2019
@skateman
Copy link
Member

@miq-bot add_reviewer @skateman

@miq-bot
Copy link
Member

miq-bot commented Oct 11, 2019

Checked commit jrafanie@9806838 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@djberg96
Copy link
Contributor

Do we have any sort of performance comparisons we can do? Just curious, I generally favor updating to the latest, especially since it seems like there have been a lot of fixes and updates since 3.7.

@himdel
Copy link
Contributor

himdel commented Oct 11, 2019

with a debugger

No issues with pry byebug, not noticing any issues with recompilation, ... LGTM IMO :)
(I didn't test actioncable or consoles.)

@skateman
Copy link
Member

Both the notifications (AC) and the consoles work well.

@jrafanie jrafanie changed the title [WIP] Update puma to latest. Be less conservative. Update puma to latest. Be less conservative. Oct 11, 2019
@miq-bot miq-bot removed the wip label Oct 11, 2019
@jrafanie jrafanie added wip core and removed wip labels Oct 11, 2019
@jrafanie
Copy link
Member Author

@Fryguy this ready to go... thanks to @himdel and @skateman for testing the debugger, consoles, and notifications

@bdunne bdunne merged commit ef015ea into ManageIQ:master Oct 17, 2019
@bdunne bdunne self-assigned this Oct 17, 2019
@bdunne bdunne added this to the Sprint 123 Ending Oct 28, 2019 milestone Oct 17, 2019
@jrafanie jrafanie deleted the update_puma branch October 17, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants