-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update puma to latest. Be less conservative. #19389
Conversation
Puma does a pretty good job about following semantic versioning so it should be safe to update minor versions and will probably help us tackle the problems sooner rather than later. https://github.com/puma/puma/blob/v4.2.1/History.md
Just to clarify, consoles are NOT using action cable 😉 only notifications. However, consoles are also running through websockets. |
Checked commit jrafanie@9806838 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Do we have any sort of performance comparisons we can do? Just curious, I generally favor updating to the latest, especially since it seems like there have been a lot of fixes and updates since 3.7. |
No issues with pry byebug, not noticing any issues with recompilation, ... LGTM IMO :) |
Both the notifications (AC) and the consoles work well. |
Puma does a pretty good job about following semantic versioning so it should be safe to update minor versions and will probably help us tackle the problems sooner rather than later.
https://github.com/puma/puma/blob/v4.2.1/History.md