Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spinner gets immediately hidden when waiting for task #6295

Closed
skateman opened this issue Oct 11, 2019 · 1 comment · Fixed by #6321
Closed

Spinner gets immediately hidden when waiting for task #6295

skateman opened this issue Oct 11, 2019 · 1 comment · Fixed by #6321
Assignees
@martinpovolny
Labels
bug

Comments

@skateman
Copy link
Member

I found this while testing consoles for ManageIQ/manageiq#19389 and it's also reproducible on master, I guess since the react toolbar rewrite. Basically the spinner gets displayed for just a fraction of second (can't even catch with the screen recorder), but the wait_for_task runs as it should until the user navigates to a different page.

Peek 2019-10-11 19-14

@miq-bot assign @martinpovolny
@skateman
Copy link
Member Author

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Oct 11, 2019
martinpovolny added a commit to martinpovolny/manageiq-ui-classic that referenced this issue Oct 22, 2019
@martinpovolny
Toolbar: pass keepSpinner to the toolbar.
9b6518e 
The hard-coded exceptions for keeping the spinner up when buttons are
pressed where removed in the React rewrite. The behavior is now driven
by the keepSpinner option on a button. However this option was not
passed from the toolbar definition to the component. Fixing that now.

Fixes: ManageIQ#6295
@martinpovolny martinpovolny mentioned this issue Oct 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinpovolny martinpovolny

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Toolbar: pass keepSpinner to the toolbar. martinpovolny/manageiq-ui-classic
3 participants
@martinpovolny @skateman @miq-bot