[HAMMER]Do not calculate backlog when subscription not active #19254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
changed the title
|
@miq-bot add-label changelog/yes |
yrudman
force-pushed
the
do-not-calculate-backlog-when-subscription-not-active
branch
from
3cf0eda to
41119f5
Compare
yrudman
force-pushed
the
do-not-calculate-backlog-when-subscription-not-active
branch
from
41119f5 to
5f023eb
Compare
gtanzillo
approved these changes
Sep 5, 2019
app/models/pglogical_subscription.rb
Outdated
| _log.error(e.message) | ||
| nil | ||
| if status != "replicating" | ||
| _log.error("Please check that database `#{dbname}` is running on host `#{host}` and accepting TCP/IP connections on port #{port}") |
There was a problem hiding this comment.
Curious why this log message is different from the one on the master PR?
There was a problem hiding this comment.
no reason, I had 2 environment 5.10 and 5.11 and always was mistake what i am testing/looking at the log, I will change it to be the same ...
|
Checked commits yrudman/manageiq@f964e0b~...52b42a0 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
The Travis error is unrelated (see: #19137 (comment)), so merging. |
yrudman
deleted the
do-not-calculate-backlog-when-subscription-not-active
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not attempt to calculate backlog unless subscription status is "replicating"
It is
hammerspecific PR to backport #19234Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1749052
@miq-bot add-label bug, core
\cc @gtanzillo