Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt to calculate backlog unless subscription status is "replicating" #19234

Merged

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Aug 30, 2019

ISSUE: There are some situation when invoking PglogicalSubscription#backlog causing UI screen to timeout

FIX: Do not attempt to calculate backlog unless subscription status is "replicating"
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1741240

@miq-bot add-label bug, core, changelog/yes, ivanchuk/yes

@yrudman yrudman force-pushed the added-backlog_str-to-miq_pglogical branch from c13b8b7 to 15c267e Compare August 30, 2019 18:23
@yrudman yrudman changed the title Do not invoke PglogicalSubscription#backlog unless subscription status is "replicating" Do not attempt to calculate backlog unless subscription status is "replicating" Aug 30, 2019
@yrudman yrudman force-pushed the added-backlog_str-to-miq_pglogical branch from 15c267e to 4907f0a Compare August 30, 2019 19:21
@yrudman
Copy link
Contributor Author

yrudman commented Sep 3, 2019

\cc @gtanzillo @bdunne

@yrudman yrudman force-pushed the added-backlog_str-to-miq_pglogical branch from 4907f0a to d073834 Compare September 3, 2019 12:25
@miq-bot
Copy link
Member

miq-bot commented Sep 3, 2019

Checked commit yrudman@d073834 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@JPrause
Copy link
Member

JPrause commented Sep 3, 2019

This PR is needed for the GA Build on Thu, Sep 05.

@yrudman
Copy link
Contributor Author

yrudman commented Sep 4, 2019

@miq-bot assign @gtanzillo

@gtanzillo gtanzillo merged commit e5f6647 into ManageIQ:master Sep 4, 2019
@gtanzillo gtanzillo added this to the Sprint 120 Ending Sep 16, 2019 milestone Sep 4, 2019
@yrudman yrudman deleted the added-backlog_str-to-miq_pglogical branch September 4, 2019 18:32
simaishi pushed a commit that referenced this pull request Sep 4, 2019
…ical

Do not  attempt to calculate backlog unless subscription status is "replicating"

(cherry picked from commit e5f6647)

https://bugzilla.redhat.com/show_bug.cgi?id=1741240
@simaishi
Copy link
Contributor

simaishi commented Sep 4, 2019

Ivanchuk backport details:

$ git log -1
commit f405925d87b651862189b518647434389dc9b18d
Author: Gregg Tanzillo <[email protected]>
Date:   Wed Sep 4 14:29:07 2019 -0400

    Merge pull request #19234 from yrudman/added-backlog_str-to-miq_pglogical
    
    Do not  attempt to calculate backlog unless subscription status is "replicating"
    
    (cherry picked from commit e5f66479e87d5e31b8f4fa85613593485df23f72)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1741240

@simaishi
Copy link
Contributor

simaishi commented Sep 5, 2019

Backported to hammer via #19254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants