-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not attempt to calculate backlog unless subscription status is "replicating" #19234
Merged
gtanzillo
merged 1 commit into
ManageIQ:master
from
yrudman:added-backlog_str-to-miq_pglogical
Sep 4, 2019
Merged
Do not attempt to calculate backlog unless subscription status is "replicating" #19234
gtanzillo
merged 1 commit into
ManageIQ:master
from
yrudman:added-backlog_str-to-miq_pglogical
Sep 4, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
force-pushed
the
added-backlog_str-to-miq_pglogical
branch
from
August 30, 2019 18:23
c13b8b7
to
15c267e
Compare
yrudman
changed the title
Do not invoke PglogicalSubscription#backlog unless subscription status is "replicating"
Do not attempt to calculate backlog unless subscription status is "replicating"
Aug 30, 2019
yrudman
force-pushed
the
added-backlog_str-to-miq_pglogical
branch
from
August 30, 2019 19:21
15c267e
to
4907f0a
Compare
\cc @gtanzillo @bdunne |
yrudman
force-pushed
the
added-backlog_str-to-miq_pglogical
branch
from
September 3, 2019 12:25
4907f0a
to
d073834
Compare
Checked commit yrudman@d073834 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
This PR is needed for the GA Build on Thu, Sep 05. |
@miq-bot assign @gtanzillo |
gtanzillo
approved these changes
Sep 4, 2019
simaishi
pushed a commit
that referenced
this pull request
Sep 4, 2019
…ical Do not attempt to calculate backlog unless subscription status is "replicating" (cherry picked from commit e5f6647) https://bugzilla.redhat.com/show_bug.cgi?id=1741240
Ivanchuk backport details:
|
Backported to hammer via #19254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE: There are some situation when invoking
PglogicalSubscription#backlog
causing UI screen to timeoutFIX: Do not attempt to calculate backlog unless subscription status is "replicating"
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1741240
@miq-bot add-label bug, core, changelog/yes, ivanchuk/yes