Removing Eo time patch #19165
Merged
Removing Eo time patch #19165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
force-pushed
the
removing_eo_time_patch
branch
from
3e54241 to
85a05ed
Compare
|
@miq-bot add_label dependencies, technical debt |
|
Per #19153 (comment) I'd like this to be backported as well if that's okay with The Powers That Be. I mean @dmetzger57 |
bdunne
reviewed
Aug 19, 2019
|
@d-m-u unrecognized command 'remove', ignoring... Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, remove_reviewer, set_milestone |
|
@miq-bot remove_label wip |
d-m-u
force-pushed
the
removing_eo_time_patch
branch
from
85a05ed to
4f55113
Compare
d-m-u
force-pushed
the
removing_eo_time_patch
branch
from
4f55113 to
f521d9f
Compare
|
Checked commit d-m-u@f521d9f with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 Gemfile
|
simaishi
pushed a commit
that referenced
this pull request
Aug 19, 2019
Removing Eo time patch (cherry picked from commit cd7ab37) https://bugzilla.redhat.com/show_bug.cgi?id=1743211
|
Ivanchuk backport details: |
|
Due to an issue found, reverted the ivanchuk backport (discussed with @d-m-u) |
simaishi
pushed a commit
that referenced
this pull request
Aug 23, 2019
Removing Eo time patch (cherry picked from commit cd7ab37) https://bugzilla.redhat.com/show_bug.cgi?id=1743211
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rufus got upgraded to 3.6! We still needed monkeypatch though for
==.#19153 got in on Friday and we had to patch EoTime == but the owner of Rufus is great and put up floraison/et-orbi@283f5e2 so we don't need this now.
see #19153 (comment)