Update rufus-scheduler to 3.6

[d-m-u]

We're using rufus-scheduler 3.1.10.2 and 3.7 is currently in the works.

To get to 3.6, there are three changes necessary:

1. job frequency was replaced by rough_frequency (jmettraux/rufus-scheduler@ba25015#diff-5d7d9fcb70b7c4ad09e1fa4b2cd82591)
2. a couple of our runner specs needed updated arguments to not break tagging

we need the patch, darn it:
3) https://github.com/floraison/et-orbi/blob/master/lib/et-orbi/time.rb#L208 pretty much just needs to be replaced with: o = EtOrbi.make_time(o)

updated to of course include the requisite picture of a rufous in all its glory:

@miq-bot assign @jrafanie

[d-m-u]

@miq-bot remove_label wip

[jrafanie]

Since it's not trivial to support both old and new rufus, maybe we should bite the bullet:

• force rufus 3.6+ or whichever version makes the most sense.
• monkey patch et-orbi to support EtOrbi::Time with Time comparisons in an initializer
• later, propose the monkey patch to upstream EtOrbi

Profit?

[miq-bot]

Checked commits d-m-u/manageiq@d6bf5b5~...5951553 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 0 offenses detected
Everything looks fine. ⭐

[Fryguy]

a couple of our runner specs needed updated arguments to not break tagging

could specs in other repos run into this issue as well?

[d-m-u]

UI's green, API's green, what else should I test for this?

[Fryguy]

That's probably fine. Merging.

[Fryguy]

@simaishi @dmetzger57 I'd like this to be backported because it eliminates a forked gem that we don't want to carry.

[dmetzger57]

I’m good with this. Just need a BZ.

[d-m-u]

https://bugzilla.redhat.com/show_bug.cgi?id=1743211

[simaishi]

Ivanchuk backport details:

$ git log -1
commit 63b2fefd3e5c4dea5ec84406e3bea9c3fdb31632
Author: Jason Frey <[email protected]>
Date:   Fri Aug 16 15:04:39 2019 -0400

    Merge pull request #19153 from d-m-u/rufus_upgrade
    
    Update rufus-scheduler to 3.6
    
    (cherry picked from commit a8aee202cf24d4bf1c176a33b0bb6e676fdee655)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1743211

[simaishi]

Due to an issue found, reverted the ivanchuk backport (discussed with @d-m-u)

commit b56570cca4852aeeee0a847d599ef9bfa4b62271
Author: Satoe Imaishi <[email protected]>
Date:   Wed Aug 21 15:53:13 2019 -0400

    Revert "Merge pull request #19153 from d-m-u/rufus_upgrade"
    
    This reverts commit 63b2fefd3e5c4dea5ec84406e3bea9c3fdb31632.

[simaishi]

Ivanchuk backport details:

$ git log -1
commit fb24d9c5c8a6b47a6c132150b207ba2f30516bff
Author: Jason Frey <[email protected]>
Date:   Fri Aug 16 15:04:39 2019 -0400

    Merge pull request #19153 from d-m-u/rufus_upgrade
    
    Update rufus-scheduler to 3.6
    
    (cherry picked from commit a8aee202cf24d4bf1c176a33b0bb6e676fdee655)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1743211

[jrafanie]

🎉 nice work @d-m-u