Fix Embedded Ansible Respository refresh #19024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtanzillo
approved these changes
Jul 22, 2019
h-kataria
approved these changes
Jul 22, 2019
|
Checked commit Fryguy@4a85261 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
Jul 22, 2019
This is probably where the issue was with the private method as mentioned and related to the following PRs: - ManageIQ#19020 - ManageIQ/manageiq-ui-classic#5849 - ManageIQ#19024 My guess is that at-Fryguy was testing this in this same branch, but split it out since it was out of scope. In the second commit of this branch, the `private` is completely removed, so fixing this here to provide context to the changes and a retrospective as to what went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gtanzillo Please review.
Somehow I made the method private, and in local testing in worked for me, but not for @h-kataria