Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2V] Have ConversionHost explicitly search authentications for auth type #18748

Merged
merged 4 commits into from
May 11, 2019
+48 −8
Merged

[V2V] Have ConversionHost explicitly search authentications for auth type #18748

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b287b5a
Explicitly search authentications for v2v.
djberg96 May 9, 2019
1ad0c51
Add explicit tests for the find_credentials method, plus add a helper…
djberg96 May 9, 2019
d3cd9a8
Just use detect in find_credentials.
djberg96 May 9, 2019
ea45831
Set the default value for auth_type to 'v2v' for the ansible_playbook…
May 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/models/conversion_host.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ def resource_supports_conversion_host
#
def find_credentials(auth_type = 'v2v')
authentication = authentication_type(auth_type)
authentication ||= authentications.detect { |a| a.authtype == auth_type }
djberg96 marked this conversation as resolved.
Show resolved Hide resolved

if authentication.blank?
res = resource.respond_to?(:authentication_type) ? resource : resource.ext_management_system
Expand Down