Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2V] Have ConversionHost explicitly search authentications for auth type #18748

Merged
merged 4 commits into from
May 11, 2019
Merged

[V2V] Have ConversionHost explicitly search authentications for auth type #18748

merged 4 commits into from
May 11, 2019

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented May 9, 2019

Within the ConversionHost model, because of the way the Authentications module was originally written, it's possible that the authentication_type('v2v') call won't actually pick up the properly authentication.

This adds a default where it will explicitly check for the auth_type if the first attempt doesn't find anything.

Fixes #18724

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1708739

@miq-bot
Copy link
Member

miq-bot commented May 10, 2019

Checked commits https://github.com/djberg96/manageiq/compare/b287b5ac3ac7638c6d3901b289dbb2b0dfcc9dee~...ea45831ca71f9053a6dbe9c39762d8795e1fc686 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

@agrare agrare merged commit 54bc9a8 into ManageIQ:master May 11, 2019
@agrare agrare self-assigned this May 11, 2019
@agrare agrare added this to the Sprint 111 Ending May 13, 2019 milestone May 11, 2019
@djberg96 djberg96 changed the title Have ConversionHost explicitly search authentications for auth type [V2V] Have ConversionHost explicitly search authentications for auth type May 14, 2019
@djberg96
Copy link
Contributor Author

@miq-bot add_label hammer/yes

simaishi pushed a commit that referenced this pull request May 20, 2019
…ook_default_credentials

Have ConversionHost explicitly search authentications for auth type

(cherry picked from commit 54bc9a8)

https://bugzilla.redhat.com/show_bug.cgi?id=1712135
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit cec25e0a0c940b555921ce361dbdf8c1eb86a93d
Author: Adam Grare <[email protected]>
Date:   Sat May 11 17:48:52 2019 -0400

    Merge pull request #18748 from djberg96/conversion_host_ansible_playbook_default_credentials
    
    Have ConversionHost explicitly search authentications for auth type
    
    (cherry picked from commit 54bc9a86e5b4199d7b4a2f7587ca8aea9136a545)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1712135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants