-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2V] Have ConversionHost explicitly search authentications for auth type #18748
Merged
agrare
merged 4 commits into
ManageIQ:master
from
djberg96:conversion_host_ansible_playbook_default_credentials
May 11, 2019
Merged
[V2V] Have ConversionHost explicitly search authentications for auth type #18748
agrare
merged 4 commits into
ManageIQ:master
from
djberg96:conversion_host_ansible_playbook_default_credentials
May 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
May 9, 2019
Checked commits https://github.com/djberg96/manageiq/compare/b287b5ac3ac7638c6d3901b289dbb2b0dfcc9dee~...ea45831ca71f9053a6dbe9c39762d8795e1fc686 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
May 11, 2019
djberg96
changed the title
Have ConversionHost explicitly search authentications for auth type
[V2V] Have ConversionHost explicitly search authentications for auth type
May 14, 2019
@miq-bot add_label hammer/yes |
simaishi
pushed a commit
that referenced
this pull request
May 20, 2019
…ook_default_credentials Have ConversionHost explicitly search authentications for auth type (cherry picked from commit 54bc9a8) https://bugzilla.redhat.com/show_bug.cgi?id=1712135
Hammer backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the
ConversionHost
model, because of the way theAuthentications
module was originally written, it's possible that theauthentication_type('v2v')
call won't actually pick up the properly authentication.This adds a default where it will explicitly check for the
auth_type
if the first attempt doesn't find anything.Fixes #18724
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1708739