[HAMMER] [V2V] ConversionHost address validation spec fixes #18692
Conversation
|
Checked commit https://github.com/djberg96/manageiq/commit/26483421fa90c15982c14f362ff91c1b8afe8af9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
| @@ -439,7 +439,7 @@ | |||
| end | |||
|
|
|||
| context "address validation" do | |||
| let(:vm) { FactoryBot.create(:host) } | |||
There was a problem hiding this comment.
Vm was a host? Was this a bad backport or was it committed to master like this?
There was a problem hiding this comment.
@agrare Can't remember, it was probably my mistake, though.
There was a problem hiding this comment.
Hm looks like this should have been fixed by https://github.com/ManageIQ/manageiq/pull/18434/files#diff-244db78f3817d010485d040e062dcd43R192
There was a problem hiding this comment.
Okay, not sure why the cherry-pick didn't pick up on this change but I'm good with this
Followup to #18690, this fixes the ConversionHost address validation specs for Hammer.