[V2V] Fix allowing address to be blank for the ConversionHost model, and update spec. #18690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label hammer/yes |
|
@miq-bot add_label bug |
djberg96
changed the title
|
@miq-bot add_label transformation |
|
@djberg96 unrecognized command 'assign_reviewer', ignoring... Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, remove_reviewer, set_milestone |
|
Checked commit https://github.com/djberg96/manageiq/commit/d89d83a4a414b08b0f0e19f47efe56ead0020c47 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Apr 26, 2019
simaishi
pushed a commit
that referenced
this pull request
Apr 26, 2019
…alidation [V2V] Fix allowing address to be blank for the ConversionHost model, and update spec. (cherry picked from commit afe8714) https://bugzilla.redhat.com/show_bug.cgi?id=1696437
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently adding
:presence => falseto the address validation for theConversionHostmodel wasn't good enough due to some AR precedence issue, and my spec didn't catch it because it already skipped the validation if the underlying resource didn't return an address.So, this explicitly skips the check if the address is blank, and updates the spec to make sure that it will return at least one address.
I validated that without this change, the spec will now fail.
Followup to: #18610
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1695797