[V2V] Allow downloading wrapper log file #18506
Conversation
ghost
mentioned this pull request
| @@ -132,20 +132,21 @@ def transformation_log | |||
|
|
|||
| # Intend to be called by UI to display transformation log. The log is stored in MiqTask#task_results | |||
| # Since the task_results may contain a large block of data, it is desired to remove the task upon receiving the data | |||
| def transformation_log_queue(userid = nil) | |||
| def transformation_log_queue(userid = nil, log_type = 'v2v') | |||
| raise "Transformation log type '#{log_type}' not supported" unless %w(v2v wrapper).include?(log_type) | |||
There was a problem hiding this comment.
Minor nitpick, I'd vote for a def valid_transformation_log_types method that returned this array instead of hardcoding it. That way down the road, we could just modify that method and/or overload it if needed. Not a showstopper, though.
ghost
force-pushed
the
v2v_download_wrapper_log
branch
from
9e45c41 to
c691b59
Compare
|
Checked commits fabiendupont/manageiq@39f465b~...c691b59 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
| @@ -113,16 +113,20 @@ def destination_security_group | |||
| SecurityGroup.find_by(:id => vm_resource.options["osp_security_group_id"]) | |||
| end | |||
|
|
|||
| def transformation_log | |||
| def valid_transformation_log_types | |||
| %w(v2v wrapper) | |||
There was a problem hiding this comment.
Is the wrapper log a superset of the v2v log? Wondering if there's any reason why someone would want to download both.
There was a problem hiding this comment.
Nope. It's a separate log. virt-v2v log is very verbose and difficult to interpret by the user. virt-v2v-wrapper log provides more comprehensive error messages when possible. When not, virt-v2v log is still a good place to look at. The support may also be interested in both when a customer opens a case.
| return create_error_status_task(userid, msg).id | ||
| end | ||
|
|
||
| _log.info("Queuing the download of transformation log for #{description} with ID [#{id}]") | ||
| _log.info("Queuing the download of #{log_type} log for #{description} with ID [#{id}]") | ||
| task_options = {:userid => userid, :action => 'transformation_log'} | ||
| queue_options = {:class_name => self.class, | ||
| :method_name => 'transformation_log', | ||
| :instance_id => id, | ||
| :priority => MiqQueue::HIGH_PRIORITY, |
There was a problem hiding this comment.
Not related to this change but...why is this HIGH_PRIORITY?? @fdupont-redhat can you put in a follow-up PR to remove the priority property? (NORMAL is the default so we dont' need to pass anything in)
[V2V] Allow downloading wrapper log file (cherry picked from commit 5307629) https://bugzilla.redhat.com/show_bug.cgi?id=1686045
|
Hammer backport details: |
In the current implementation, we provide a download button in the UI that allows downloading the virt-v2v log file. It's been reported by field that the virt-v2v-wrapper log is more relevant and provides better error messages. This PR allows downloading the wrapper log.
The
transformation_logmethod becomes more generic by accepting alog_typeargument. The defaultlog_typevalue isv2vto not break code calling it. Thetransformation_log_queuemethod gates the log type to allow onlyv2vandwrapper. The migration log controller has been modified to leverage this new feature in ManageIQ/manageiq-v2v#887.Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1655124