This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
V2v specify migration log type #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Checked commits https://github.com/fdupont-redhat/manageiq-v2v/compare/42a883d5816ee9ee41cc87df5ab9b57d6e75395b~...150d3b4a62a1a87b82c79789e48bcc8440e3ff78 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
|
Waiting to merge this until after ManageIQ/manageiq#18506 is merged. |
This was referenced Mar 1, 2019
mzazrivec
approved these changes
Mar 4, 2019
ghost
deleted the
simaishi
pushed a commit
that referenced
this pull request
Mar 6, 2019
…_type V2v specify migration log type (cherry picked from commit e8713e2) https://bugzilla.redhat.com/show_bug.cgi?id=1686045
|
Hammer backport details: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, we provide a download button in the UI that allows downloading the virt-v2v log file. It's been reported by field that the virt-v2v-wrapper log is more relevant and provides better error messages. This PR allows downloading the wrapper log.
We pass an extra parameter
log_typethat defaults tov2vto not break existing API calls. We have extended the ServiceTemplateTransformationPlanTask model accordingly in ManageIQ/manageiq#18506.Part of #885.
Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1655124