Add empty IP address check to preflight check

[ghost]

With Linux virtual machines, we have at least two known cases where the IP address for an NIC is empty: 1. ghost config files(ifcfg-*) ; 2. the NIC has more than one IPv4 or one IPv6 address on the NIC. This leads to generating network mappings for conversion with nil addresses, which in turn causes the conversion to fail, as virt-v2v-wrapper can't handle nil addresses.

This PR adds a preflight check on the transformation task to verify that no interface in the mapping has a nil address. The goal is to fail early in the transformation process and not even stop the source VM, preserving the source environment.

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1671719

[ghost]

@miq-bot add-label transformation, enhancement, hammer/yes
@miq-bot add-reviewer jameswnl, jerryk55, djberg96

[miq-bot]

@fdupont-redhat 'jameswnl, jerryk55, djberg96' is an invalid reviewer, ignoring...

[jerryk55]

@fdupont-redhat do you want a message with the 'raise'? Otherwise looks fine.

[ghost]

@jerryk55 I don't want a message at the moment. We also works on enhanced error reporting and the message structure is not decided yet. I will add a message in another PR, along with others ;)

[jerryk55]

@fdupont-redhat sounds good.

[djberg96]

👍

[miq-bot]

@fdupont-redhat 'jameswnl, jerryk55, djberg96' is an invalid reviewer, ignoring...

[JPrause]

@fdupont-redhat was this PR reviewed and ready for merge. We need this for an upcoming hammer build.

[ghost]

@jerryk55 @jameswnl @djberg96 could you do a last review and merge if everything's ok ?

[djberg96]

@miq-bot add_reviewer @jerryk55

[djberg96]

@miq-bot add_reviewer @jameswnl

[djberg96]

@miq-bot add_reviewer @djberg96

[agrare]

@fdupont-redhat it looks like most of the existing validation is done in the calculate_abcd methods, would be more consistent to do this check down here

manageiq/app/models/service_template_transformation_plan_task.rb

Line 258 in cf83a9b

raise "[#{source.name}] NIC #{nic.device_name} [#{source_network.name}] has no mapping." if destination_network.nil?

[miq-bot]

Checked commits fabiendupont/manageiq@cf83a9b~...3eb1681 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

[agrare]

👍 awesome @fdupont-redhat !

[simaishi]

Hammer backport details:

$ git log -1
commit d0ee8411a35d08aba5578eeb34791597e666ba53
Author: Adam Grare <[email protected]>
Date:   Fri Feb 15 11:25:33 2019 -0500

    Merge pull request #18425 from fdupont-redhat/v2v_preflight_nic_ip_address
    
    Add empty IP address check to preflight check
    
    (cherry picked from commit 3d262608700abe96aa0659a506660fcf161204d3)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1678376