Add nil IP address check to preflight check

ManageIQ · Jan 31, 2019 · cf83a9b · cf83a9b
1 parent 6752229
commit cf83a9b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/app/models/service_template_transformation_plan_task.rb b/app/models/service_template_transformation_plan_task.rb
@@ -54,7 +54,7 @@ def task_active
   def preflight_check
     destination_cluster
     virtv2v_disks
-    network_mappings
+    network_mappings.each { |m| raise if m.ip_address.nil? }
     raise if destination_ems.emstype == 'openstack' && source.power_state == 'off'
     true
   rescue

diff --git a/spec/models/service_template_transformation_plan_task_spec.rb b/spec/models/service_template_transformation_plan_task_spec.rb
@@ -453,6 +453,8 @@
           )
         end
 
+        it { expect(task_1.preflight_check). to be false }
+
         context "transport method is vddk" do
           before do
             conversion_host.vddk_transport_supported = true
@@ -542,6 +544,8 @@
           )
         end
 
+        it { expect(task_1.preflight_check). to be false }
+
         context "transport method is vddk" do
           before do
             conversion_host.vddk_transport_supported = true