Add fullscreen title to MiqReportResult #18359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lpichler Cannot apply the following label because they are not recognized: report |
1 task
gtanzillo
reviewed
Jan 22, 2019
app/models/miq_report_result.rb
Outdated
| @@ -51,6 +52,10 @@ class MiqReportResult < ApplicationRecord | |||
|
|
|||
| delegate :table, :to => :report_results, :allow_nil => true | |||
|
|
|||
| def full_screen_title | |||
There was a problem hiding this comment.
How about making this name more generic like friendly_title?
MiqReportResult is used for Report and for Widgets but when we are displaying report result in full screen for widget we need to display name of widget and this method is used for this reason.
lpichler
force-pushed
the
add_fullscreen_title_to_report_result
branch
from
5eedc58 to
0d8dbcf
Compare
|
Checked commits lpichler/manageiq@68778ec~...0d8dbcf with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MiqReportResultis used for Report and for Widgetsbut when we are displaying report result in full screen
for widget we need to display name of widget and
this method is used for this reason.
Links
@miq-bot assign @gtanzillo
@miq-bot add_label report, bug