Display widget's title in full screen of widget result #5159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lpichler Cannot apply the following label because they are not recognized: pending backend |
|
Checked commit lpichler@30e31f7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@lpichler The backend PR link you linked above is not correct. |
|
@mzazrivec yes thanks ! |
|
This pull request is not mergeable. Please rebase and repush. |
lpichler
force-pushed
the
display_title_from_widget_in_full_screen_report
branch
from
30e31f7 to
8bb0490
Compare
|
@mzazrivec backend PR merged and this PR rebased => ready to review 👍 |
|
@miq-bot remove_label pending core, unmergeable |
mzazrivec
reviewed
Feb 7, 2019
| @@ -2,7 +2,7 @@ | |||
| %html.layout-pf.layout-pf-fixed.transitions{:lang => I18n.locale.to_s.sub('-', '_')} | |||
| %head | |||
| %title | |||
| = "%{product}: %{title}" % {:product => Vmdb::Appliance.PRODUCT_NAME, :title => @report.title} | |||
| = "%{product}: %{title}" % {:product => Vmdb::Appliance.PRODUCT_NAME, :title => @report_title} | |||
There was a problem hiding this comment.
The whitespace before @report_title is unnecessary.
there is used title from report for report result
lpichler
force-pushed
the
display_title_from_widget_in_full_screen_report
branch
from
8bb0490 to
cfd5c27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backend
dashboard
full screen
Links
@miq-bot add_label pending backend, bug