Refactor Refresher and ManagerRefresh methods #18312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
refactor_manager_refresher
branch
from
e49b025 to
1d76d07
Compare
agrare
force-pushed
the
refactor_manager_refresher
branch
from
1d76d07 to
fe34636
Compare
agrare
changed the title
agrare
force-pushed
the
refactor_manager_refresher
branch
from
c4c0717 to
fac2bde
Compare
|
This pull request is not mergeable. Please rebase and repush. |
The Refresher and ManagerRefresher classes do the same thing in slightly different ways leading to confusion.
agrare
force-pushed
the
refactor_manager_refresher
branch
from
fac2bde to
48cbb6b
Compare
agrare
changed the title
|
Checked commits agrare/manageiq@fe65889~...48cbb6b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Ladas
approved these changes
Feb 13, 2019
|
@gtanzillo can you take a look? |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Refresher and ManagerRefresher classes do the same thing in slightly different ways leading to confusion.
Both of these handle configurably using graph refresh or legacy refresh but do it in different ways, this attempts to unify these two.
Ovirt refresher parse_targeted_inventory returns inventory_collections not persister