Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parse_targeted_inventory to call inv.parse #328

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

agrare
Copy link
Member

@agrare agrare commented Dec 21, 2018

Instead of calling inventory.inventory_collections and return an array
of inventory collections, convention is to call inventory.parse and
return a persister which is handled easier by the subsequent
save_inventory method.

Instead of calling inventory.inventory_collections and return an array
of inventory collections, convention is to call inventory.parse and
return a persister which is handled easier by the subsequent
save_inventory method.
@miq-bot
Copy link
Member

miq-bot commented Dec 21, 2018

Checked commit agrare@b6521d7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@Fryguy Fryguy merged commit 63fca48 into ManageIQ:master Dec 21, 2018
@Fryguy Fryguy added the bug label Dec 21, 2018
@Fryguy Fryguy added this to the Sprint 102 Ending Jan 7, 2019 milestone Dec 21, 2018
@Fryguy Fryguy self-assigned this Dec 21, 2018
@agrare agrare deleted the fix_parser_to_return_inventory_parse branch December 21, 2018 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants