Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GAPRINDASHVILI] Skip tags without classification assigments #18096

Merged
merged 3 commits into from
Oct 15, 2018
Merged

[GAPRINDASHVILI] Skip tags without classification assigments #18096

merged 3 commits into from
Oct 15, 2018

Conversation

lpichler
Copy link
Contributor

@simaishi simaishi requested a review from gtanzillo October 15, 2018 14:24
@miq-bot
Copy link
Member

miq-bot commented Oct 15, 2018

Checked commits lpichler/manageiq@877a5db~...59e4e4c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

gtanzillo
gtanzillo approved these changes Oct 15, 2018
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@simaishi simaishi merged commit aa2df14 into ManageIQ:gaprindashvili Oct 15, 2018
@simaishi simaishi added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 15, 2018
@simaishi simaishi mentioned this pull request Oct 15, 2018
Merged
@lpichler lpichler deleted the skip_tags_without_classification_assigments_g branch October 15, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@simaishi simaishi

Labels
blocker bug core/chargeback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpichler @miq-bot @gtanzillo @simaishi