Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tags without classification in assigments #17883

Merged

Conversation

lpichler
Copy link
Contributor

Not sure how this could be possible but I found it in customer's DB when I came to the
CI -> Chargeback Assigments

it was causing issue here because ChargebackRate.get_assignments("Compute") was returning:

[[Classification object, "vm"], [nil, "vm"], ...] and the such second element is causing bug in UI.

@miq-bot assign @gtanzillo
@miq-bot add_label chargeback, bug

@miq-bot
Copy link
Member

miq-bot commented Aug 21, 2018

Checked commits lpichler/manageiq@18db19b~...b461b65 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@lpichler
Copy link
Contributor Author

lpichler commented Aug 21, 2018

this bug occurred probably after https://bugzilla.redhat.com/show_bug.cgi?id=1612889
it is edge case.

@miq-bot
Copy link
Member

miq-bot commented Aug 21, 2018

@lpichler Cannot apply the following label because they are not recognized: gapridanshvili/yes

@lpichler
Copy link
Contributor Author

@miq-bot add_label gaprindashvili/yes

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gtanzillo gtanzillo added this to the Sprint 93 Ending Aug 27, 2018 milestone Aug 21, 2018
@gtanzillo gtanzillo merged commit c9eb88e into ManageIQ:master Aug 21, 2018
@lpichler lpichler deleted the skip_tags_without_classification_assigments branch August 21, 2018 13:46
@yrudman
Copy link
Contributor

yrudman commented Oct 11, 2018

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1637902

@simaishi
Copy link
Contributor

@lpichler #get_assigned_tos test doesn't exist in Gaprindashvili branch. Should I just backport the changes in app/models/mixins/assignment_mixin.rb or can you create a separate PR with appropriate test for G branch?

@lpichler
Copy link
Contributor Author

@simaishi I will create the PR for G branch, thanks!

@simaishi
Copy link
Contributor

Backported to Gaprindashvili via #18096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants