Prevent queueing things for a zone that doesn't exist in the region #17987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
force-pushed
the
ensure_zone_is_valid
branch
4 times, most recently
from
0d1d1b0 to
c388f33
Compare
jrafanie
reviewed
Sep 14, 2018
spec/models/miq_queue_spec.rb
Outdated
| it "without a matching region" do | ||
| expect { MiqQueue.create!(:state => "ready", :zone => "Missing Zone") }.to raise_error(ActiveRecord::RecordInvalid) | ||
| end | ||
| end |
There was a problem hiding this comment.
@bdunne I glanced at the tests but didn't see one for a message with a nil zone... does that pass this validation and not raise an error?
bdunne
force-pushed
the
ensure_zone_is_valid
branch
from
c388f33 to
bf66236
Compare
|
Checked commit bdunne@bf66236 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM for master. cc @gtanzillo |
borod108
pushed a commit
to borod108/manageiq-providers-ovirt
that referenced
this pull request
Sep 16, 2018
Fixing a test that was broken due to a PR that added validation to zone when putting a task into MiqQueue. (ManageIQ/manageiq#17987)
|
Fix for ui-classic ManageIQ/manageiq-ui-classic#4669 . Is this |
bdunne
added a commit
to bdunne/manageiq-automation_engine
that referenced
this pull request
Sep 18, 2018
Broken by validations added in ManageIQ/manageiq#17987
|
@bdunne As per ManageIQ/manageiq-api#472 (comment), I'm assuming this should be Can you please create a separate PR for Gaprindashvili branch? |
bdunne
pushed a commit
to bdunne/manageiq
that referenced
this pull request
Oct 8, 2018
Prevent queueing things for a zone that doesn't exist in the region https://bugzilla.redhat.com/show_bug.cgi?id=1635764 (cherry picked from commit 01c28d5)
|
@bdunne is this still in conflict for gaprindashvili backport? |
|
Backported to Gaprindashvili via #18068 |
cben
pushed a commit
to cben/manageiq-providers-kubernetes
that referenced
this pull request
Nov 1, 2018
…_failing_on_missing_zone Fix MetricsCapture and Refresher specs failing due to a missing zone Stubbing MiqServer.my_zone to return a dummy string was affecting the zone with which events were added to MiqQueue, which broke now that MiqQueue requires a real zone (ManageIQ/manageiq#17987).
cben
pushed a commit
to cben/manageiq-providers-openshift
that referenced
this pull request
Nov 1, 2018
…ing_zone Fix specs failing on a missing zone Stubbing MiqServer.my_zone to return a dummy string was affecting the zone with which events were added to MiqQueue, which broke now that MiqQueue requires a real zone (ManageIQ/manageiq#17987).
cben
added a commit
to cben/manageiq-providers-kubernetes
that referenced
this pull request
Nov 1, 2018
Stubbing MiqServer.my_zone to return a dummy string was affecting the zone with which events were added to MiqQueue, which broke now that MiqQueue requires a real zone (ManageIQ/manageiq#17987).
|
Looks like this is generating a sql call for every insert into miq_queue. Wonder if we want to do some sort of caching for this value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1628658