Fix specs failing on a missing zone #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
fix_failing_spec_on_missing_zone
branch
from
e743d52 to
95a537b
Compare
|
Checked commit agrare@95a537b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
cben
pushed a commit
to cben/manageiq-providers-openshift
that referenced
this pull request
Nov 1, 2018
…ing_zone Fix specs failing on a missing zone Stubbing MiqServer.my_zone to return a dummy string was affecting the zone with which events were added to MiqQueue, which broke now that MiqQueue requires a real zone (ManageIQ/manageiq#17987).
This was referenced Nov 1, 2018
|
Backported to Gaprindashvili via #124 |
simaishi
added
gaprindashvili/yes
gaprindashvili/backported
and removed
gaprindashvili/yes
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of specs were failing due to a missing zone and a new MiqQueue validation