virtual column for parent blue folder path with excluded non-display folders #17976
Conversation
|
@bzwei Can you please review? |
|
I would recommend making change in https://github.com/ManageIQ/manageiq/blob/master/app/models/transformation_mapping.rb#L87 to utilize this virtual column in this PR. |
AparnaKarve
force-pushed
the
virtual_col_blue_path_exclude_non_display_folders
branch
from
f9521f8 to
552e782
Compare
|
@bzwei Per your recommendation, I have utilized the virtual column in the |
|
LGTM, wait for CI passed. |
|
@bzwei, @AparnaKarve are we ready to merge this? It's the last piece I need to finish ManageIQ/manageiq-v2v#620. Thanks so much for getting this in so quickly! |
|
@gmcculloug Can you review and merge? |
app/models/vm_or_template.rb
Outdated
| @@ -803,6 +804,11 @@ def parent_datacenter | |||
| end | |||
| alias_method :owning_datacenter, :parent_datacenter | |||
|
|
|||
| def parent_blue_folder_path_with_excluded_non_display_folders | |||
There was a problem hiding this comment.
I think something like parent_blue_folder_display_path would be a better name
app/models/vm_or_template.rb
Outdated
| @@ -151,6 +151,7 @@ class VmOrTemplate < ApplicationRecord | |||
| virtual_column :v_owning_blue_folder, :type => :string, :uses => :all_relationships | |||
| virtual_column :v_owning_blue_folder_path, :type => :string, :uses => :all_relationships | |||
| virtual_column :v_datastore_path, :type => :string, :uses => :storage | |||
| virtual_column :v_folder_path_no_non_display_folders, :type => :string, :uses => :all_relationships | |||
There was a problem hiding this comment.
All of the other virtual_columns for the parent_blue_folders are called parent_blue_folder_something ref so to keep it consistent how about v_parent_blue_folder_display_path ?
There was a problem hiding this comment.
Sure... as long as the name fits in that space that the other virtual columns are using
-- and it does!
I have renamed the method and the virtual column per your suggestion.
Thanks.
AparnaKarve
force-pushed
the
virtual_col_blue_path_exclude_non_display_folders
branch
from
552e782 to
26289cb
Compare
AparnaKarve
force-pushed
the
virtual_col_blue_path_exclude_non_display_folders
branch
from
26289cb to
d3709e0
Compare
|
Checked commit AparnaKarve@d3709e0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/models/vm_or_template.rb
|
|
@agrare Thanks for the review! |
AparnaKarve
deleted the
virtual_col_blue_path_exclude_non_display_folders
branch
The new virtual column has been added to make the
v_folder_path_no_non_display_foldersattribute accessible via theapi/vmsAPI.In v2v UI, we currently display the path info via API for VMs which internally calls this method - https://github.com/ManageIQ/manageiq/blob/master/app/models/transformation_mapping.rb#L83
We are currently in the process of adding Edit support for Plans, where we will need this attribute accessible to us via
api/vmsAPI