[#607] Edit an existing RHV migration plan #620
Conversation
mturley
force-pushed
the
edit-plan
branch
4 times, most recently
from
0cf2eb4 to
c4e9376
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -39,3 +39,23 @@ export const csvParseErrorAction = errMsg => dispatch => { | |||
| payload: errMsg | |||
| }); | |||
| }; | |||
|
|
|||
| const _queryPrefilledVmsActionCreator = ids => dispatch => { | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
mturley
force-pushed
the
edit-plan
branch
4 times, most recently
from
18c6a54 to
13da006
Compare
| @@ -39,3 +39,23 @@ export const csvParseErrorAction = errMsg => dispatch => { | |||
| payload: errMsg | |||
| }); | |||
| }; | |||
|
|
|||
| const _queryPreselectedVmsActionCreator = ids => dispatch => { | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
This pull request is not mergeable. Please rebase and repush. |
| const { postPlansUrl, postMigrationPlansAction, plansBody, planSchedule } = this.props; | ||
|
|
||
| postMigrationPlansAction(postPlansUrl, plansBody, planSchedule); | ||
| const { postPlansUrl, postMigrationPlansAction, putPlansUrl, putMigrationPlansAction, plansBody, planSchedule, editingPlan } = this.props; |
There was a problem hiding this comment.
Similar blocks of code found in 9 locations. Consider refactoring.
| const { postPlansUrl, postMigrationPlansAction, plansBody, planSchedule } = this.props; | ||
|
|
||
| postMigrationPlansAction(postPlansUrl, plansBody, planSchedule); | ||
| const { postPlansUrl, postMigrationPlansAction, putPlansUrl, putMigrationPlansAction, plansBody, planSchedule, editingPlan } = this.props; |
There was a problem hiding this comment.
Similar blocks of code found in 10 locations. Consider refactoring.
| return this.renderError(__('Error Creating Migration Plan'), errorMessage, hidePlanWizardAction); | ||
| } else if (isPuttingPlans) { | ||
| return this.renderSpinner(__('Saving Migration Plan...'), __('Please wait while the migration plan is saved.')); | ||
| } else if (isRejectedPuttingPlans) { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| const { postPlansUrl, postMigrationPlansAction, plansBody, planSchedule } = this.props; | ||
|
|
||
| postMigrationPlansAction(postPlansUrl, plansBody, planSchedule); | ||
| const { |
There was a problem hiding this comment.
Similar blocks of code found in 10 locations. Consider refactoring.
|
This pull request is not mergeable. Please rebase and repush. |
mturley
force-pushed
the
edit-plan
branch
2 times, most recently
from
2cb1b56 to
39fba8d
Compare
|
As soon as @AparnaKarve's PR ManageIQ/manageiq#17976 is merged, I'll be able to fix the path column in the VM step, and then this PR will be ready for review. |
…n depending on state
|
Checked commits mturley/manageiq-v2v@96fe78c~...af17a37 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Looks great @mturley
and seems to work nicely with the WIP backend PR
This is for #607, but will not close it yet because it is disabled until backend support is ready.
Closes #646.