Load all the values along with their key names into the field update method #17973
Conversation
|
@miq-bot assign @gmcculloug |
|
Failure, smailure, it's the same sporadic failure we're seeing everywhere, the number precision thingy, it's got nothing to do with this change. |
app/models/dialog.rb
Outdated
| @@ -89,7 +89,7 @@ def validate_field_data | |||
| end | |||
|
|
|||
| def load_values_into_fields(values, overwrite = true) | |||
| values = values.with_indifferent_access | |||
| values = values.with_indifferent_access if values.kind_of?(Hash) | |||
There was a problem hiding this comment.
What else could values be if not a hash?
There was a problem hiding this comment.
It's a string in the api tests.
There was a problem hiding this comment.
That sounds wrong to me, especially when [] is called on it here
There was a problem hiding this comment.
Sounds like the tests need to be fixed
d-m-u
force-pushed
the
fixing_tests_on_api_pr_448
branch
from
cc65351 to
65d21d1
Compare
d-m-u
changed the title
d-m-u
changed the title
d-m-u
changed the title
d-m-u
force-pushed
the
fixing_tests_on_api_pr_448
branch
from
65d21d1 to
545e4bc
Compare
d-m-u
changed the title
|
@miq_bot remove_label wip |
|
The fact that this doesn't break any tests (before or after the change) makes me think we don't have enough tests around it... |
d-m-u
force-pushed
the
fixing_tests_on_api_pr_448
branch
from
545e4bc to
428ec31
Compare
d-m-u
force-pushed
the
fixing_tests_on_api_pr_448
branch
from
428ec31 to
966dc9d
Compare
|
Checked commit d-m-u@966dc9d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@bdunne I think this should be g/yes cause it's for a g bug. |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1594469.
The main changes that got merged a little while ago, combined with #17855, break the custom actions API specs on ManageIQ/manageiq-api#448 because I'm an idiot who wrote that line that's breaking this to start with which shouldn't be just loading the values and definitely shouldn't just be loading the first one. Mea maxima culpa.