-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass changed dialog field values to resource_action_workflow #448
Conversation
@miq-bot add_label bug, blocker, gaprindashvili/yes |
Checked commit d-m-u@26bde70 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change itself looks ok, but the specs appear to be breaking because we need to have the method signature change from ManageIQ/manageiq#17855 implemented first.
@miq-bot remove_label wip |
@abellotti or @gtanzillo or anyone can you please 👀 for me? |
@d-m-u Is this change covered by an existing test? |
Sure @gtanzillo, the linked main PR has the spec: https://github.com/ManageIQ/manageiq/pull/17855/files#diff-e4c49a3a89dbb44fc8e72282858f91eeR67 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@miq-bot remove_label wip |
@miq-bot remove_label blocker |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1594469
I think that the api needs to be passing the changed dialog field values into the resource action workflow when we make the submit workflow call. Otherwise the field values automate sees by the time we get to https://github.com/ManageIQ/manageiq/blob/master/app/models/resource_action_workflow.rb#L81 will be the default values only, not the updated fields you changed on the dialog.
The setup this applies to is a custom button on a generic object.
Depends on:
ManageIQ/manageiq#17855ManageIQ/manageiq#17973