Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sysprep support for oVirt provider #17636

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Add sysprep support for oVirt provider #17636

merged 1 commit into from
Sep 17, 2018

Conversation

borod108
Copy link

@borod108 borod108 commented Jun 26, 2018 •
edited
Loading

Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833

What:
Add sysprep specification support for vm provisioning from template
for the oVirt provider.

Steps to see the dialog:
Compute -> Infrastructure -> Virtual Machines
Lifecycle -> Provision VMs
Select a template with a Windows OS.
Go to the "Customization" tab.
Under Basic Options open the "Customize" drop down.

Before:
selection_016

After:
selection_014

And then after selecting "Sysprep Specification":

image

@Fryguy
Copy link
Member

Fryguy commented Jun 27, 2018

@borod108 If this is WIP (as per your second commit), can you please change the title to include [WIP] at the front

@Fryguy
Copy link
Member

Fryguy commented Jun 27, 2018

Also, please don't leave the pull request template as your PR message. Please fill it in with the intent of this PR.

Also, also

borod108 added some commits on Jan 3

How is that possible? :)

@bdunne bdunne changed the title Rfe/sysprep [WIP] Rfe/sysprep Jul 5, 2018
@bdunne bdunne added the wip label Jul 5, 2018
@borod108 borod108 force-pushed the rfe/sysprep branch 2 times, most recently from 228108b to 008232b Compare August 5, 2018 15:48
@borod108
Copy link
Author

borod108 commented Aug 5, 2018

@Fryguy wow, sorry I opened the pull request back then by mistake, and did not even notice you commented on it :/

@agrare can you please take a look? (or maybe point to someone who should)

borod108 pushed a commit to borod108/manageiq-ui-classic that referenced this pull request Aug 5, 2018
Add sysprep support for ovirt
e054326 
Add sysprep specification support for vm provisioning from template
for the oVirt provider.

Depends on: ManageIQ/manageiq#17636
Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833
@borod108 borod108 mentioned this pull request Aug 5, 2018
Merged
borod108 pushed a commit to borod108/manageiq-providers-ovirt that referenced this pull request Aug 5, 2018
Add sysprep support for ovirt
c80b0b6 
Add sysprep specification support for vm provisioning from template
for the oVirt provider.

Depends on: ManageIQ/manageiq#17636
Required for: ManageIQ/manageiq-ui-classic#4211
Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833
@borod108 borod108 mentioned this pull request Aug 5, 2018
Merged
@borod108 borod108 changed the title [WIP] Rfe/sysprep Add sysprep support for oVirt provider Aug 5, 2018
@borod108
Copy link
Author

borod108 commented Aug 5, 2018

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Aug 5, 2018
borod108 pushed a commit to borod108/manageiq-providers-ovirt that referenced this pull request Aug 8, 2018
Add sysprep support for ovirt
1c090a2 
Add sysprep specification support for vm provisioning from template
for the oVirt provider.

Depends on: ManageIQ/manageiq#17636
Required for: ManageIQ/manageiq-ui-classic#4211
Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833
@agrare
Copy link
Member

agrare commented Aug 8, 2018

cc @gmcculloug @bdunne

@borod108
Copy link
Author

borod108 commented Aug 8, 2018

@miq-bot add_label wip
got some feedback need to add couple of fields.

@miq-bot miq-bot changed the title Add sysprep support for oVirt provider [WIP] Add sysprep support for oVirt provider Aug 8, 2018
@miq-bot miq-bot added the wip label Aug 8, 2018
borod108 pushed a commit to borod108/manageiq-providers-ovirt that referenced this pull request Aug 9, 2018
Add sysprep support for ovirt
6313933 
Add sysprep specification support for vm provisioning from template
for the oVirt provider.

Depends on: ManageIQ/manageiq#17636
Required for: ManageIQ/manageiq-ui-classic#4211
Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833
borod108 pushed a commit to borod108/manageiq-providers-ovirt that referenced this pull request Aug 9, 2018
Add sysprep support for ovirt
97f17f2 
Add sysprep specification support for vm provisioning from template
for the oVirt provider.

Depends on: ManageIQ/manageiq#17636
Required for: ManageIQ/manageiq-ui-classic#4211
Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833
borod108 pushed a commit to borod108/manageiq-ui-classic that referenced this pull request Aug 9, 2018
Add sysprep support for ovirt
0ce0e6a 
Add sysprep specification support for vm provisioning from template
for the oVirt provider.

Depends on: ManageIQ/manageiq#17636
Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833
@borod108
Copy link
Author

borod108 commented Aug 9, 2018

@miq-bot remove_label wip
added missing fields.

@miq-bot miq-bot changed the title [WIP] Add sysprep support for oVirt provider Add sysprep support for oVirt provider Aug 9, 2018
@miq-bot miq-bot removed the wip label Aug 9, 2018
@agrare
Copy link
Member

agrare commented Aug 22, 2018

Sending over to @gmcculloug for final review

@gmcculloug
Copy link
Member

@borod108 Looks good, I think we just need to include the sysprep_* dialog fields in the miq_provision_redhat_dialogs_clone_to_vm.yaml file as well.

@borod108
Copy link
Author

@gmcculloug done

@borod108 borod108 closed this Aug 27, 2018
@borod108 borod108 reopened this Aug 27, 2018
@gmcculloug
Copy link
Member

@borod108 Looks good. If you remove the wip label (also PR title) we can merge it.

borod108 pushed a commit to borod108/manageiq-providers-ovirt that referenced this pull request Aug 29, 2018
Add sysprep support for ovirt
9b87201 
Add sysprep specification support for vm provisioning from template
for the oVirt provider.

Depends on: ManageIQ/manageiq#17636
Required for: ManageIQ/manageiq-ui-classic#4211
Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833
@gmcculloug
Copy link
Member

@borod108 just realized this is not merged yet. Any reason to keep it WIP?

borod108 pushed a commit to borod108/manageiq-providers-ovirt that referenced this pull request Sep 13, 2018
Add sysprep support for ovirt
d15001e 
Add sysprep specification support for vm provisioning from template
for the oVirt provider.

Depends on: ManageIQ/manageiq#17636
Required for: ManageIQ/manageiq-ui-classic#4211
Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833
borod108 pushed a commit to borod108/manageiq-providers-ovirt that referenced this pull request Sep 13, 2018
Add sysprep support for ovirt
d0a77c2 
Add sysprep specification support for vm provisioning from template
for the oVirt provider.

Depends on: ManageIQ/manageiq#17636
Required for: ManageIQ/manageiq-ui-classic#4211
Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833
Add sysprep support for ovirt
9535039 
Add sysprep specification support for vm provisioning from template
for the oVirt provider.

Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833
borod108 pushed a commit to borod108/manageiq-providers-ovirt that referenced this pull request Sep 16, 2018
Add sysprep support for ovirt
4c1cb91 
Add sysprep specification support for vm provisioning from template
for the oVirt provider.

Depends on: ManageIQ/manageiq#17636
Required for: ManageIQ/manageiq-ui-classic#4211
Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833
@miq-bot
Copy link
Member

miq-bot commented Sep 16, 2018

Checked commit borod108@9535039 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

borod108 pushed a commit to borod108/manageiq-providers-ovirt that referenced this pull request Sep 16, 2018
Add sysprep support for ovirt
5badb97 
Add sysprep specification support for vm provisioning from template
for the oVirt provider.

Depends on: ManageIQ/manageiq#17636
Required for: ManageIQ/manageiq-ui-classic#4211
Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833
borod108 pushed a commit to borod108/manageiq-providers-ovirt that referenced this pull request Sep 16, 2018
Add sysprep support for ovirt
0a82432 
Add sysprep specification support for vm provisioning from template
for the oVirt provider.

Depends on: ManageIQ/manageiq#17636
Required for: ManageIQ/manageiq-ui-classic#4211
Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833
@borod108
Copy link
Author

@miq-bot remove_label wip

@borod108 borod108 closed this Sep 17, 2018
@borod108 borod108 reopened this Sep 17, 2018
@miq-bot miq-bot changed the title [WIP] Add sysprep support for oVirt provider Add sysprep support for oVirt provider Sep 17, 2018
@miq-bot miq-bot removed the wip label Sep 17, 2018
@borod108
Copy link
Author

@agrare can we merge please?

@gmcculloug
Copy link
Member

@borod108 @agrare PR ManageIQ/manageiq-providers-ovirt#275 should be merged first since this PR adds a call to get_timezones.

@agrare
Copy link
Member

agrare commented Sep 17, 2018

@gmcculloug merged the ovirt pr

@gmcculloug gmcculloug merged commit dc331ac into ManageIQ:master Sep 17, 2018
@gmcculloug gmcculloug added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 17, 2018
borod108 pushed a commit to borod108/manageiq-ui-classic that referenced this pull request Sep 19, 2018
Add sysprep support for ovirt
8eba0b7 
Add sysprep specification support for vm provisioning from template
for the oVirt provider.

Depends on: ManageIQ/manageiq#17636
Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcculloug gmcculloug gmcculloug left review comments

@agrare agrare agrare approved these changes

Assignees

@gmcculloug gmcculloug

Labels
enhancement providers/infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@borod108 @Fryguy @agrare @gmcculloug @miq-bot @martinpovolny @bdunne