Add sysprep support for ovirt

[borod108]

Add sysprep specification support for vm provisioning from template
for the oVirt provider.

Depends on: ManageIQ/manageiq#17636
Required for: ManageIQ/manageiq-ui-classic#4211
Implements: https://bugzilla.redhat.com/show_bug.cgi?id=1553833

[pkliczewski]

@borod108 please add a spec so we can make sure that sysprep flow works correctly

[pkliczewski]

sysprep_option = get_option(:sysprep_enabled)

Does sysprep_option contain fields or "Sysprep Specification"? Can we replace dig with it?

[pkliczewski]

It looks like we could use sysprep_specification_selected? here.

BTW This line cause travis to fail with:

undefined method `[]' for nil:NilClass

[borod108]

@agrare this is not nice :( perhaps you know a better way to do it? (anyway I can do it in the automation/ui side somehow defining I want only the value without the key? currently it returns ["300", "(GMT+13:00) Nuku'alofa"])

[agrare]

Hm I think the automate workflow should use 300 as the key and pass down the value /cc @gmcculloug ??

[gmcculloug]

Fields displayed as drop-downs in the UI are stored as an array with [key, display_name], which is what you are seeing here.

Values like this in the options hash are normally processed in the backend using the get_option method which handles parsing the field and only returning the first key if it is an array. For VMware, which is the only other provider to use a timezone drop-down today, this is handled in the backend model and the parsed value is passed to the provider.

If the only thing you need to pass for substitution is the key then I think you would do:
substitution_options[:timezone] = get_option(substitution_options[:timezone])

If that works for you a small refactoring of this would be:

def prepare_customization_template_substitution_options
  super.tap do |substitution_options|
    substitution_options[:sysprep_timezone] = get_option(substitution_options[:sysprep_timezone])
  end
end

If you think you need to pass both key and display_name you could setup a second key here as well and there is a get_option_last helper method. For example:

substitution_options[:sysprep_timezone_name] = get_option_last(substitution_options[:sysprep_timezone])

[gmcculloug]

@borod108 Did my suggestion not work out? I'm curious about the details.

[miq-bot]

Checked commit borod108@0a82432 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍪