Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Schedule time values #17547

Closed
wants to merge 9 commits into from
Closed

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jun 7, 2018

This is build on a few other PRs, but the last commit addresses #17520 (comment)
Depends on:
#17542
ManageIQ/manageiq-schema#212
#17545

@bdunne bdunne requested a review from gmcculloug June 7, 2018 17:11
@miq-bot
Copy link
Member

miq-bot commented Jun 7, 2018

Some comments on commits bdunne/manageiq@d881e84~...bb29981

spec/models/miq_schedule_spec.rb

  • ⚠️ - 717 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@miq-bot
Copy link
Member

miq-bot commented Jun 7, 2018

Checked commits bdunne/manageiq@d881e84~...bb29981 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 3 offenses detected

app/models/miq_request.rb

spec/models/miq_schedule_spec.rb

@bdunne bdunne changed the title Schedule time values [WIP] Schedule time values Jun 11, 2018
@miq-bot miq-bot added the wip label Jun 11, 2018
@miq-bot
Copy link
Member

miq-bot commented Jun 15, 2018

This pull request is not mergeable. Please rebase and repush.

@bdunne
Copy link
Member Author

bdunne commented Jun 15, 2018

Closing since v2v is interacting with ServiceTemplates instead of MiqRequests

@bdunne bdunne closed this Jun 15, 2018
@bdunne bdunne deleted the schedule_time_values branch June 15, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants