[WIP] Change MiqRequest to use MiqSchedules for scheduled requests

[bdunne]

While working on the V2V project, there are a few use cases around scheduled requests that need some enhancements. In order to accommodate those use cases, it would be best to use schedules rather than queue items with a deliver on date.

Desired V2V features:

• Schedule a new request (already exists)
• Unschedule a request
• Reschedule a request

This is currently using a reserve column since it needs to be backported. I will create a followup PR here and in manageiq-schema to get out of the reserved attribute.

Follow-ups:
ManageIQ/manageiq-schema#212
#17545

[bdunne]

This includes the change in #17520

[miq-bot]

Some comments on commits bdunne/manageiq@d881e84~...a443211

spec/models/miq_schedule_spec.rb

• ⚠️ - 717 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

[miq-bot]

Checked commits bdunne/manageiq@d881e84~...a443211 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 2 offenses detected

app/models/miq_request.rb

• ❗ - Line 429, Col 20 - Style/RescueModifier - Avoid using rescue in its modifier form.

spec/models/miq_schedule_spec.rb

• ❗ - Line 708, Col 25 - Style/WordArray - Use %w or %W for an array of words.

[agrare]

D'oh I meant to put this here

Copying @gmcculloug 's comment (#17520 (comment))

I would recommend that we refactor this line. The classic UI sets get_option(:schedule_time) to a ActiveSupport::TimeWithZone object which supports the utc call.

I suspect that if this is set from the API or some other means it would set the time as a string in which case the code will silently error and use nil. It is also a good opportunity to get rid of the inline rescue as well.

[agrare]

Fixed by #17547

[agrare]

This looks good to me, I wonder if we should unify the invoke_actions in MiqSchedule eventually or add an action_create_miq_request_tasks so it is consistent with how the rest of the actions are.

[bdunne]

@agrare Yeah, I was hoping to remove the action_ methods and move any necessary logic to the class that it belongs in.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[bdunne]

Closing since v2v is interacting with ServiceTemplates instead of MiqRequests