Removes last call to automate from dialog_field serializer #17436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
d-m-u
force-pushed
the
excluding_values_from_serializer
branch
from
fef9113 to
7aded49
Compare
eclarizio
suggested changes
May 18, 2018
d-m-u
force-pushed
the
excluding_values_from_serializer
branch
from
7aded49 to
5415cc1
Compare
|
Checked commit d-m-u@5415cc1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@eclarizio Specs added. Please take another look |
This was referenced May 21, 2018
|
@eclarizio yeah, i believe so |
|
This fixed my issue. Once @eclarizio signs off on the specs, I'm good to go. Thanks @d-m-u 👏 |
|
@eclarizio Let's associate this PR with BZ https://bugzilla.redhat.com/show_bug.cgi?id=1570298. |
|
@d-m-u Cannot apply the following label because they are not recognized: all_the_bugs_are_scared_of_brandon |
simaishi
pushed a commit
that referenced
this pull request
Jun 11, 2018
Removes last call to automate from dialog_field serializer (cherry picked from commit 1009681) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1589837
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field serializer shouldn't be calling automate, so any call to values needs to be removed. I think this was the last one. We've had multiple issues with automate running more times than it needs to and this is at least partially a fix for those type of issues.
Should fix #17446
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1570298