Dialog field loading/refresh refactor to fix automate delays

[eclarizio]

This PR is intended to fix an issue where the automate methods for dialog fields were running multiple times for seemingly no reason. Upon loading of a dialog (via custom button click or service catalog order, for example), sometimes dialog fields would also run in a seemingly random order. We figured out that due to the way the #value method was written for some of the dialog field types, those would call the automate method first, before the method #initialize_with_values was called.

However, #initialize_with_values was kind of misnamed, as it was really more about just establishing values for the context in the ResourceActionWorkflow. So, I've renamed that method and adjusted the logic around when it gets called.

Another large change is that the DialogFieldSerializer was making a call to the automate methods because if a field was dynamic it would try to get the values for that field. However, I don't think this should be the job of the serializer, it should simply serialize what it's given. So if something needs to update, it now does so before calling into the serializer.

For a refresh, #initialize_with_values was closer to the correct name of describing what needed to be done, but I also added #load_values_into_fields for when the dialog needs to refresh. Note that the logic to go into this method depends upon an option that gets passed in from this API PR.

This PR touches all of the DialogField types and the Dialog model itself, as well as the ResourceActionWorkflow, which are (obviously) how every single dialog do their thing. Therefore, this PR should undergo a much more rigorous test before merging. QE is involved in helping test this PR as well.

Needs ManageIQ/manageiq-api#365 to be merged first.

https://bugzilla.redhat.com/show_bug.cgi?id=1559757
https://bugzilla.redhat.com/show_bug.cgi?id=1571000

[eclarizio]

@miq-bot add_label wip

[gmcculloug]

@d-m-u Please review

[miq-bot]

Checked commits eclarizio/manageiq@956d9b5~...dac46a2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
18 files checked, 0 offenses detected
Everything looks fine. 🍪

[eclarizio]

@miq-bot remove_label wip

Un-WIP-ing and updated the top comment with more context. Would be nice to have multiple reviews on this as well!

[tinaafitz]

@eclarizio Looks good.

[gmcculloug]

We have been testing heavily on this PR and at this point not seeing issues with the automate methods running extra runs. Nice performance improvements overall. 👍

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 8545d9a074ed9b93d2ac726fd20a66428fd934fc
Author: Greg McCullough <[email protected]>
Date:   Thu Apr 26 19:19:54 2018 -0400

    Merge pull request #17329 from eclarizio/dialog_field_dynamic_loading_sev2
    
    Dialog field loading/refresh refactor to fix automate delays
    (cherry picked from commit c719d7f3867ec1c70a7d6dda92149b3e45eab093)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1572716
    https://bugzilla.redhat.com/show_bug.cgi?id=1572711