Clean chargeback vm spec after 17271 #17303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lpichler Cannot apply the following label because they are not recognized: technical_debt |
bdunne
reviewed
Apr 16, 2018
spec/models/chargeback_vm_spec.rb
Outdated
| @@ -750,21 +750,21 @@ def result_row_for_vm(vm) | |||
|
|
|||
| subject { Chargeback::RatesCache.new.get(consumption).first } | |||
|
|
|||
| before(:each) do | |||
There was a problem hiding this comment.
The (:each) is unnecessary, it is the default
lpichler
force-pushed
the
clean_chargeback_vm_spec
branch
from
d183262 to
de10a55
Compare
|
Checked commits lpichler/manageiq@b86a4f1~...de10a55 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some leftovers after #17271
@miq-bot assign @bdunne
@miq-bot add_label technical_debt, test