Add cloud volumes for selecting assigned tagged resources #17271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit lpichler@e61541c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label gaprindashvili/yes |
gtanzillo
approved these changes
Apr 10, 2018
simaishi
pushed a commit
that referenced
this pull request
May 15, 2018
Add cloud volumes for selecting assigned tagged resources (cherry picked from commit 447f26e) https://bugzilla.redhat.com/show_bug.cgi?id=1578394
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assigning
ratefor storages by tags on cloud volumes (by optionTagged datastores) did not work for chargeback without including metrics.it can be set here:
Fix
Fix was about to include also
resource's cloud_volumesfor selecting rates inConsumptionWithoutRollups#parents_determining_ratefor calling method to select rate:https://github.com/ManageIQ/manageiq/blob/master/app/models/chargeback/rates_cache.rb#L24
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1559807
@miq-bot assign @gtanzillo
@miq-bot add_label bug, chargeback