-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fine] Fine tag mapping #17068
[Fine] Fine tag mapping #17068
Conversation
Needed for ManageIQ/manageiq-providers-amazon#417 |
@cben does this look correct to you? |
I'll take a deeper look tomorrow, but I suspect some more stuff needs to be backported. E.g. See ManageIQ/manageiq-providers-kubernetes#126 for cheat sheet of PRs (wow, that's horrifically long 😳) |
@cben will explain why I wasn't sure if it was working ManageIQ/manageiq-providers-amazon#417 (comment) I'll compare more against that PR thanks! |
@cben - FYI his PRs are: |
Did Azure provider support graph refresh in Fine? Hmm, on second thought there is some dependency there.
Then if you'll also want mapping in graph refresh in Fine (for Amazon?), you'd need a much bigger part of ManageIQ/manageiq-providers-kubernetes#126... I'm not sure that's worth it & safe enough to backport. |
Thanks @cben |
…olled_by_mapping scope"
Checked commits juliancheal/manageiq@8808666~...6ad243b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/models/manageiq/providers/cloud_manager.rb
|
Decided not to go ahead with backporting tag mapping to Fine. |
Backport of Tag mapping in Graph refresh
#16734
plus additional methods required
Fixes BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1537111