Use new ContainerLabelTagMapping::Mapper interface #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose mapper to save_inventory_container which will use it to find/create all referenced tags.
23 tasks
|
Checked commit cben@81aacb9 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM |
|
These can only pass after the core PR is merged |
|
@cben I merged it |
agrare
approved these changes
Oct 17, 2017
|
@cben Can we backport to Fine and Gaprindashvili? |
|
Already in gaprindashvili. Applies cleanly to fine. |
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/plan issue: ManageIQ/manageiq-providers-kubernetes#126
To be merged simultaneously with ManageIQ/manageiq#16098 and ManageIQ/manageiq-providers-kubernetes#130. Can't pass Travis until the core PR lands.
@djberg96 please review.