[Fine] Fine tag mapping

[juliancheal]

Backport of Tag mapping in Graph refresh

#16734
plus additional methods required

Fixes BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1537111

[juliancheal]

Needed for ManageIQ/manageiq-providers-amazon#417

[juliancheal]

@cben does this look correct to you?

[cben]

I'll take a deeper look tomorrow, but I suspect some more stuff needs to be backported. E.g. controlled_by_mapping seems not used anywhere, ContainerLabelTagMapping::Mapper doesn't exist yet, so I think this still can't map in graph refresh (?)

See ManageIQ/manageiq-providers-kubernetes#126 for cheat sheet of PRs (wow, that's horrifically long 😳)

[juliancheal]

I suspect some more stuff needs to be backported. E.g. controlled_by_mapping seems not used anywhere, ContainerLabelTagMapping::Mapper doesn't exist yet, so I think this still can't map in graph refresh (?)

@cben will explain why I wasn't sure if it was working ManageIQ/manageiq-providers-amazon#417 (comment)

I'll compare more against that PR thanks!

[bronaghs]

@cben -
@ AlexanderZagaynov is implementing tagging support for the Azure provider, it is a blocker for the next Fine errata. Is his work dependent on this PR getting merged?

FYI his PRs are:
#17212
ManageIQ/manageiq-providers-azure#231

[cben]

Did Azure provider support graph refresh in Fine?
IIUC you're separating the graph refresh from classic refresh PRs in Azure tag mapping precisely because you only need classic refresh in Fine?

Hmm, on second thought there is some dependency there.
I changed the interface of the ContainerLabelTagMapping when I added graph refresh support. So just taking a refresh parser using the new interface and backporting it will not work against the old interface.
I think the minimal parts you need to backport to Fine are:

• ContainerLabelTagMapping::Mapper class, separate tag creation #16098 changing the interface, introducing Mapper class.
  EDIT: doesn't apply cleanly, requires several steps, see cben/FINE-tag-mapper branch if you want it.
• Use new ContainerLabelTagMapping::Mapper interface manageiq-providers-kubernetes#130, EDIT: and Use new ContainerLabelTagMapping::Mapper interface manageiq-providers-amazon#316 — adapt refreshes to new interface

Then if you'll also want mapping in graph refresh in Fine (for Amazon?), you'd need a much bigger part of ManageIQ/manageiq-providers-kubernetes#126... I'm not sure that's worth it & safe enough to backport.

[juliancheal]

Thanks @cben

[miq-bot]

Checked commits juliancheal/manageiq@8808666~...6ad243b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 3 offenses detected

app/models/manageiq/providers/cloud_manager.rb

• ❗ - Line 38, Col 46 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.
• ❗ - Line 38, Col 54 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 38, Col 59 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.

[juliancheal]

Decided not to go ahead with backporting tag mapping to Fine.