Add reindex to job scheduler #16929
Merged
Add reindex to job scheduler #16929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jntullo
commented
Feb 1, 2018
app/models/vmdb_metric.rb
Outdated
| @@ -31,4 +32,9 @@ def self.rollup_metrics(resource, _interval_name, rollup_date) | |||
| # Create new daily record... | |||
| metric.update_attributes(:rows => rows, :size => size, :wasted_bytes => wasted_bytes, :percent_bloat => percent_bloat) | |||
| end | |||
|
|
|||
| def self.reindex_table_name | |||
| "metrics_#{DateTime.now.utc.hour}" | |||
There was a problem hiding this comment.
Also I think this should be on Metric not VmdbMetric
carbonin
reviewed
Feb 1, 2018
| class_methods do | ||
| def reindex | ||
| _log.info("Reindexing table #{reindex_table_name}") | ||
| result = ActiveRecord::Base.connection.execute("REINDEX TABLE #{reindex_table_name}") |
There was a problem hiding this comment.
We can use the methods defined here for this.
carbonin
reviewed
Feb 1, 2018
| @@ -143,6 +143,12 @@ def metric_purge_all_timer | |||
| end | |||
| end | |||
|
|
|||
| def database_maintenance_reindex_timer | |||
| %w(VmdbMetric MiqQueue MiqWorker).each do |class_name| | |||
There was a problem hiding this comment.
I wonder if it would be easier to keep this list in a setting then have the class implement just the reindex_table method.
Then we could just add the .reindex method here and avoid the mixin entirely.
What do you think?
jntullo
force-pushed
the
db_maintenance
branch
4 times, most recently
from
4893d5b to
3958e37
Compare
jntullo
changed the title
This schedules reindex on VmdbMetric, MiqQueue, MiqWorker on an hourly schedule
jntullo
force-pushed
the
db_maintenance
branch
from
3958e37 to
3da7e63
Compare
|
Checked commit jntullo@3da7e63 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
This was referenced Feb 2, 2018
|
@jntullo Please add BZ link. |
|
@jntullo Backport of a few other PRs is blocked until this PR gets into gaprindashvili... Please create a BZ if it doesn't exist, and link other related PRs to the BZ as well. Thanks! |
simaishi
pushed a commit
that referenced
this pull request
Mar 9, 2018
Add reindex to job scheduler (cherry picked from commit da512b2) https://bugzilla.redhat.com/show_bug.cgi?id=1553795
|
Gaprindashvili backport details: |
3 tasks
jrafanie
added a commit
to jrafanie/manageiq-appliance_console
that referenced
this pull request
Apr 24, 2018
https://bugzilla.redhat.com/show_bug.cgi?id=1571246 Fixes: translation missing: en.advanced_settings.db_maintenance in Advanced Settings menu of the appliance console. The DB maintenance menu was removed in: ManageIQ#32 It was replaced with: ManageIQ/manageiq#16929 ManageIQ/manageiq#16940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a reindex of
Metric,MiqQueue,MiqWorkerto run hourly via the job scheduler. At present, this is configured on the appliance console and done via cron jobs on the database appliance.Will be following up with scheduling of vacuum on tables.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1553772
@miq-bot add_label wip
@miq-bot assign @carbonin