Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove database maintenance from appliance console #32

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

jntullo
Copy link

@jntullo jntullo commented Feb 2, 2018

✂️ ✂️

No longer needed after ManageIQ/manageiq#16929 and ManageIQ/manageiq#16940

@miq-bot assign @carbonin

@abellotti
Copy link
Member

more ✂️ fun for @jrafanie

@carbonin
Copy link
Member

carbonin commented Feb 2, 2018

@jntullo Can you also remove these from the locales files?

@jntullo jntullo force-pushed the remove_db_maintenance branch from 522568e to cb7cc44 Compare February 5, 2018 12:32
@miq-bot
Copy link
Member

miq-bot commented Feb 5, 2018

Checked commit jntullo@cb7cc44 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@kbrock
Copy link
Member

kbrock commented Feb 5, 2018

nice. would love to get this stuff out of the rake files too (another day)

Copy link
Member

@carbonin carbonin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really want to merge this until we're sure that we have all the blocker issues in.

I don't want to get into a situation where we have to cut a release for a blocker fix and have do pull some git magic to avoid this change (which we don't want in a release just yet).

No changes need to be made, but I want to make sure @jrafanie doesn't come along and merge this in too early 😉

@jrafanie
Copy link
Member

jrafanie commented Feb 8, 2018

No changes need to be made, but I want to make sure @jrafanie doesn't come along and merge this in too early 😉

Should we make this WIP until then?

@carbonin
Copy link
Member

nice. would love to get this stuff out of the rake files too (another day)

@kbrock I don't think any of this is in rake files... At least none of what we'll be using after this change.
Can you point us to what you're referencing? Could be another area that needs to be cleaned up after this change.

@kbrock
Copy link
Member

kbrock commented Feb 12, 2018

@carbonin sorry - it was tangental.

I was thinking of the overlapping code in [evm_dba.rake]

@carbonin carbonin merged commit da72d74 into ManageIQ:master Feb 28, 2018
@carbonin carbonin added this to the Sprint 81 Ending Mar 12, 2018 milestone Feb 28, 2018
jrafanie added a commit to jrafanie/manageiq-appliance_console that referenced this pull request Apr 24, 2018
https://bugzilla.redhat.com/show_bug.cgi?id=1571246

Fixes: translation missing: en.advanced_settings.db_maintenance in
Advanced Settings menu of the appliance console.

The DB maintenance menu was removed in:
ManageIQ#32

It was replaced with:

ManageIQ/manageiq#16929
ManageIQ/manageiq#16940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants