-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove database maintenance from appliance console #32
Conversation
more ✂️ fun for @jrafanie |
@jntullo Can you also remove these from the locales files? |
522568e
to
cb7cc44
Compare
Checked commit jntullo@cb7cc44 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 **
|
nice. would love to get this stuff out of the rake files too (another day) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really want to merge this until we're sure that we have all the blocker issues in.
I don't want to get into a situation where we have to cut a release for a blocker fix and have do pull some git magic to avoid this change (which we don't want in a release just yet).
No changes need to be made, but I want to make sure @jrafanie doesn't come along and merge this in too early 😉
Should we make this WIP until then? |
@kbrock I don't think any of this is in rake files... At least none of what we'll be using after this change. |
@carbonin sorry - it was tangental. I was thinking of the overlapping code in [evm_dba.rake] |
https://bugzilla.redhat.com/show_bug.cgi?id=1571246 Fixes: translation missing: en.advanced_settings.db_maintenance in Advanced Settings menu of the appliance console. The DB maintenance menu was removed in: ManageIQ#32 It was replaced with: ManageIQ/manageiq#16929 ManageIQ/manageiq#16940
✂️ ✂️
No longer needed after ManageIQ/manageiq#16929 and ManageIQ/manageiq#16940
@miq-bot assign @carbonin