Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass target object when evaluating expression for Generic Object #16858

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Jan 19, 2018

*Issue:
call toGenericObject#custom_actions was delegated to GenericObjectDefinition. As a result, evaluating expression defined on GenericObject would get GenericObjectDefinition as target (instead of GenericObject)
Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1553767

There was similar issue with evaluating expression for Service addressed here: #16770
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1505988

\cc @gtanzillo @gmcculloug

@miq-bot
Copy link
Member

miq-bot commented Jan 19, 2018

Checked commits yrudman/manageiq@e654e16~...4b1d05d with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🏆

@yrudman
Copy link
Contributor Author

yrudman commented Jan 22, 2018

@miq-bot add-label gaprindashvili/yes, bug, core

@chessbyte chessbyte self-assigned this Jan 23, 2018
@chessbyte chessbyte merged commit 20c5a84 into ManageIQ:master Jan 23, 2018
@chessbyte chessbyte added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 23, 2018
@yrudman yrudman deleted the fixed-expression-evaluation-for-generic-object branch January 23, 2018 19:07
@simaishi
Copy link
Contributor

simaishi commented Mar 6, 2018

@yrudman Since the referenced BZ is for service (and already closed), need a different BZ to track this particular change.

@yrudman
Copy link
Contributor Author

yrudman commented Mar 6, 2018

@simaishi that BZ (https://bugzilla.redhat.com/show_bug.cgi?id=1505988) is in POST, can i just add another PR to it ?

@simaishi
Copy link
Contributor

simaishi commented Mar 6, 2018

@yrudman You'll need to look at the 5.9 clone since this is a backport to gaprindashvili branch
https://bugzilla.redhat.com/show_bug.cgi?id=1535153

We can't use the same BZ when 1 PR is already in a released downstream build and BZ is CLOSED/ERRATA.

And since that BZ is specifically talking about Service, we should track this separately anyway...

@yrudman
Copy link
Contributor Author

yrudman commented Mar 9, 2018

simaishi pushed a commit that referenced this pull request Mar 9, 2018
…r-generic-object

Pass target object when evaluating expression for Generic Object
(cherry picked from commit 20c5a84)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553836
@simaishi
Copy link
Contributor

simaishi commented Mar 9, 2018

Gaprindashvili backport details:

$ git log -1
commit 87c54f142f371811366eea13d351b4bdd0d91b1b
Author: Oleg Barenboim <[email protected]>
Date:   Tue Jan 23 11:48:32 2018 -0500

    Merge pull request #16858 from yrudman/fixed-expression-evaluation-for-generic-object
    
    Pass target object when evaluating expression for Generic Object
    (cherry picked from commit 20c5a8446f35935d9bf28afb5bf8c3b237a76077)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants