-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass target object when evaluating expression for Generic Object #16858
Pass target object when evaluating expression for Generic Object #16858
Conversation
…ns to use for expression evaluatiion
Checked commits yrudman/manageiq@e654e16~...4b1d05d with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
@miq-bot add-label gaprindashvili/yes, bug, core |
@yrudman Since the referenced BZ is for service (and already closed), need a different BZ to track this particular change. |
@simaishi that BZ (https://bugzilla.redhat.com/show_bug.cgi?id=1505988) is in POST, can i just add another PR to it ? |
@yrudman You'll need to look at the 5.9 clone since this is a backport to gaprindashvili branch We can't use the same BZ when 1 PR is already in a released downstream build and BZ is CLOSED/ERRATA. And since that BZ is specifically talking about Service, we should track this separately anyway... |
…r-generic-object Pass target object when evaluating expression for Generic Object (cherry picked from commit 20c5a84) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553836
Gaprindashvili backport details:
|
*Issue:
call to
GenericObject#custom_actions
was delegated toGenericObjectDefinition
. As a result, evaluating expression defined onGenericObject
would getGenericObjectDefinition
as target (instead ofGenericObject
)Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1553767
There was similar issue with evaluating expression for
Service
addressed here: #16770BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1505988
\cc @gtanzillo @gmcculloug