-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed expression evaluation for custom button in CustomActionMixin #16770
Merged
gtanzillo
merged 4 commits into
ManageIQ:master
from
yrudman:fixed-expression-evaluation-for-custom-button
Jan 16, 2018
Merged
Fixed expression evaluation for custom button in CustomActionMixin #16770
gtanzillo
merged 4 commits into
ManageIQ:master
from
yrudman:fixed-expression-evaluation-for-custom-button
Jan 16, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
force-pushed
the
fixed-expression-evaluation-for-custom-button
branch
5 times, most recently
from
January 10, 2018 15:13
65b2c8c
to
5bbcb20
Compare
yrudman
force-pushed
the
fixed-expression-evaluation-for-custom-button
branch
2 times, most recently
from
January 13, 2018 00:05
a546420
to
f55f588
Compare
yrudman
changed the title
[WIP] Fixed expression evaluation for custom button in CustomActionMixin
Fixed expression evaluation for custom button in CustomActionMixin
Jan 13, 2018
@miq-bot add_label gaprindashvili/yes |
…ixin in order to evaluate expression attached to custom button om class level. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1505988
…d on 'applies_to_class' attribute of button.
yrudman
force-pushed
the
fixed-expression-evaluation-for-custom-button
branch
from
January 15, 2018 19:29
f55f588
to
a9a8d4f
Compare
Checked commits yrudman/manageiq@d2716e0~...a9a8d4f with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jan 16, 2018
…r-custom-button Fixed expression evaluation for custom button in CustomActionMixin (cherry picked from commit 091a546) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1535153
Gaprindashvili backport details:
|
This was referenced Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1505988
MiqExpressions
for Custom Action defined onService
class are built based onService
model.MiqExpressions
for Custom Action defined onServiceTemplate
are built based onServiceTemplate
model.Before:
CustomActionMixin
did not have ability to evaluate actions defined on template or class differently. Expression were evaluated in the same way using instance ofServcieTemplate
, regardless where button come from -ServcieTemplate
orService
class.As a result, evaluating expression for custom action defined on
Service
class was throwing error:NoMethodError: undefined method
vms' for #ServiceTemplate:0x007fd4b6f74490`After:
Use different object for expression evaluation: instance of
Service
for actions defined onService
and instance ofServiceTemplate for action defined on
ServicesTemplate`@miq-bit add-label bug, core
\cc @lpichler @gtanzillo