Allow users already in UPN format #16849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Classic UI peels the domain from the userid before authenticating. The SSUI does not. These changes will make username matching more robust. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1424618
|
@abellotti Please merge when tests pass. |
|
@miq-bot assign @abellotti |
|
@miq-bot add_babels bug, authentication |
|
@jvlcek unrecognized command 'add_babels', ignoring... Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
|
@miq-bot add_labels bug, authentication |
|
Checked commit jvlcek@e2fe6bf with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label gaprindashvili/yes |
abellotti
approved these changes
Jan 18, 2018
simaishi
pushed a commit
that referenced
this pull request
Jan 18, 2018
Allow users already in UPN format (cherry picked from commit 91aa9fb) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536221
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Classic UI peels the domain from the userid before authenticating.
The SSUI does not.
These changes will make username matching more robust by supporting both a username with and without the domain portion.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1424618
Related PRs:
Converting userids to UPN format to avoid duplicate user records 15535
Add support for the domain user attribute 127
Document support for the domain user attribute 424
Add support for the external auth domain user attribute 250
[FINE] Do not downcase the amazon IAM username #15959
If the userid is not found in the DB do a case insensitive search 15904
Steps for Testing/QA