Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the external auth domain user attribute #250

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

jvlcek
Copy link
Member

@jvlcek jvlcek commented Jul 25, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1424618

This PR is paired with PR 15535 in the ManageIQ/manageiq repo. Both must be merged at the same time.

Note:

This change requires new support in the underlying SSSD code. Updates were
required to provide the domain name when MiQ is configured to use External Authentication (Mode: External (httpd)

The BZs that track this work are:

BZ 1425891
BZ 1455254
The fixes for these BZs are targeted for RHEL 7.4 GA and CentOS 7.4

Therefor this change should not be merged until MiQ appliance builds migrate to RHEL 7.4 GA and CentOS 7.4

Testing:

  • With the associated PR in place use the appliance console to configure: Configure External Authentication (httpd)
  • Configure the appliance for external authentication
  • Add a valid group
  • login with a valid user
  • confirm the user record has a userid in User Principal Name format

@jvlcek
Copy link
Member Author

jvlcek commented Jul 25, 2017

@gtanzillo and @abellotti please review.

I have tested this change on a live appliance configured with the associated PRs.

@miq-bot
Copy link
Member

miq-bot commented Jul 25, 2017

Checked commit jvlcek@9ccbb45 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gtanzillo gtanzillo added this to the Sprint 68 Ending Sep 4, 2017 milestone Aug 31, 2017
@gtanzillo gtanzillo merged commit a895542 into ManageIQ:master Aug 31, 2017
simaishi pushed a commit that referenced this pull request Sep 5, 2017
Add support for the external auth domain user attribute
(cherry picked from commit a895542)

https://bugzilla.redhat.com/show_bug.cgi?id=1487689
@simaishi
Copy link
Contributor

simaishi commented Sep 5, 2017

Fine backport details:

$ git log -1
commit bd6144de033033d827b1c7c85be40cf2fef4bddb
Author: Gregg Tanzillo <[email protected]>
Date:   Thu Aug 31 18:19:29 2017 -0400

    Merge pull request #250 from jvlcek/bz1424618_dup_users
    
    Add support for the external auth domain user attribute
    (cherry picked from commit a8955426ccd2492a51934a3f7bfe45b291072a38)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1487689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants